refactor(dashboards): remove last_refresh from dashboard_tile #24004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +31 B (0%) Total Size: 1.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
skoob13
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Going down a rabbit hole on what the
updateTileOnDashboardsthat was added in #12271 does, I found that it's main purpose was updating thelast_refreshattribute of a dashboard tile (not the attribute of the insight, but the tile!). It looks like we do not use this attribute anywhere anymore and the implementation was broken meanwhile, so that the original intention ofupdateTileOnDashboardsisn't working any more. For example when you (1) open a dashboard (2) navigate to an insight (3) edit it's name (4) navigate back, the insight name would not have been updated.Changes
This PR removes unused functionality and fixes insight updates on dashboards like the above. It also refactors two usages of
insight.dashboards(deprecated) to useinsight.dashboard_tilesinstead.How did you test this code?
CI run + testing the insight update